Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak/separate host up func #166

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Tweak/separate host up func #166

merged 3 commits into from
Apr 1, 2024

Conversation

vdjagilev
Copy link
Owner

Closes #157

@vdjagilev vdjagilev added priority/low Low priority issue type/other An issue that do not fall under the category of a bug or a feature tech/go Golang tech/html HTML (or markup + templates) is involved tech/markdown Markdown involved tech/excel labels Apr 1, 2024
@vdjagilev vdjagilev self-assigned this Apr 1, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.75%. Comparing base (3259deb) to head (5811889).

Files Patch % Lines
formatter/formatter_excel.go 80.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           v3-dev     #166      +/-   ##
==========================================
+ Coverage   81.58%   81.75%   +0.16%     
==========================================
  Files          22       22              
  Lines         782      800      +18     
==========================================
+ Hits          638      654      +16     
- Misses         86       87       +1     
- Partials       58       59       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vdjagilev vdjagilev merged commit 1705552 into v3-dev Apr 1, 2024
8 of 9 checks passed
@vdjagilev vdjagilev deleted the tweak/separate-host-up-func branch April 1, 2024 20:37
vdjagilev added a commit that referenced this pull request Jun 2, 2024
@vdjagilev
Tweak/separate host up func (#166)
ec90a15 
* refactor: IsUp function for host

* tweak: more variations for should-skip-host func

* cicd: codeql fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vdjagilev vdjagilev

Labels
priority/low Low priority issue tech/excel tech/go Golang tech/html HTML (or markup + templates) is involved tech/markdown Markdown involved type/other An issue that do not fall under the category of a bug or a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vdjagilev